Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate readthedocs "config via UI" to .readthedocs.yaml #116

Merged
merged 2 commits into from
Aug 5, 2023
Merged

Conversation

JOJ0
Copy link
Owner

@JOJ0 JOJ0 commented Aug 5, 2023

Fixes: #114

dev branch seems to build fine now. I tested by deleting all the configurations from rtd-UI (Admin - Advanced Settings - Default Settings)

master/latest is failing right now but that is expected. It should build fine again after mergen this PR, which I will do without waiting for a review. This is just an informative PR to keep our merge history tidy.

A minimalistic config as suggested in readthedocs' migration-configuration-v2
docs.
Copy link
Collaborator

@JacksonChen666 JacksonChen666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't look obviously wrong but that's about it

@JOJ0
Copy link
Owner Author

JOJ0 commented Aug 5, 2023

There is some flake8 code style errors. There might have been some changes in the defaults of the flake8 gh-actions is using and we didn't pin down what errors we enforce. I will ignore them now and fix in a separate PR.

@JOJ0 JOJ0 merged commit 0f7e2aa into master Aug 5, 2023
@JOJ0
Copy link
Owner Author

JOJ0 commented Aug 5, 2023

Perfect, latest is buidling fine now: https://readthedocs.org/projects/synadm/builds/21514259/
So this is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prepare for Read the Docs Configuration v2
2 participants